Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrade runtime and development dependencies to newer minor/patch versions, updating both package.json and pnpm-lock.yaml to keep the app, type definitions, and tooling current. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `package.json:85` </location>
<code_context>
"eslint-plugin-react-hooks": "^4.6.2",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"react-resize-observer": "^1.1.1",
"rollup-plugin-copy": "3.4.0",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align `jest-environment-jsdom` major version with the core Jest version to avoid subtle test environment issues.
`jest` is still on `^29.7.0` while `jest-environment-jsdom` is `^30.2.0`. The environment package usually matches Jest’s major version, and using v30 with Jest v29 can cause subtle test breakage (e.g. different globals or setup behavior). Please either keep `jest-environment-jsdom` on 29.x or upgrade Jest (and related tools like `ts-jest`) in sync.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This pull request upgrades multiple dependencies to their latest minor or patch versions, focusing on keeping the project up-to-date with recent improvements and bug fixes.
Key Changes:
- Upgraded core UI and SDK packages (
@deskpro/app-sdk,@deskpro/deskpro-ui) - Updated React ecosystem libraries including query management, routing, and time formatting
- Bumped development tooling including testing, linting, and build tools
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Updated 16 dependency versions (both production and development) with minor/patch version bumps |
| pnpm-lock.yaml | Comprehensive lock file update reflecting all dependency changes and their transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@tanstack/react-query": "^4.40.1", | ||
| "formik": "^2.4.6", | ||
| "javascript-time-ago": "^2.5.11", | ||
| "@fortawesome/react-fontawesome": "^0.2.6", |
There was a problem hiding this comment.
The upgraded version of @fortawesome/react-fontawesome (0.2.6) is marked as deprecated in the lock file. According to the deprecation notice, version 0.2.x is no longer supported, and you should update to v3.1.1 or greater unless you are still using FontAwesome 5.
Consider upgrading to the latest stable version (v3.x) to ensure continued support and compatibility with FontAwesome 6.
| "@fortawesome/react-fontawesome": "^0.2.6", | |
| "@fortawesome/react-fontawesome": "^3.1.1", |
| "eslint-plugin-react-hooks": "^4.6.2", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^30.0.5", | ||
| "jest-environment-jsdom": "^30.2.0", |
There was a problem hiding this comment.
The upgraded whatwg-encoding@3.1.1 package is deprecated in favor of @exodus/bytes. While this is a transitive dependency (via jsdom), you should monitor this deprecation as it may affect future compatibility if not addressed in upstream packages.
|
Build for commit bbcaaf4 deployed to: https://shortcut-pr-78.ci.next.deskprodemo.com URLs: |
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These upgrades include both production and development dependencies, aiming to keep the project up to date with recent bug fixes, features, and security improvements.Dependency updates:
@deskpro/app-sdk,@deskpro/deskpro-ui,@fortawesome/react-fontawesome,@sentry/react,@sentry/vite-plugin,@tanstack/react-query,formik, andjavascript-time-agoto their latest patch or minor versions.react-router-dom,react-time-ago, andstyled-componentsto more recent versions.Development and type dependency updates:
@typespackages (e.g.,@types/lodash,@types/react) to newer versions for improved TypeScript compatibility. [1] [2]eslint-config-prettier,jest-environment-jsdom, andviteto their latest patch or minor releases.Summary by Sourcery
Update project dependencies to newer minor and patch versions for runtime and tooling packages.
Build: